Skip to content

chore: fix typos, grammar, and minor issues across multiple packages#11167

Merged
kgryte merged 1 commit intodevelopfrom
philipp/fix-review-2026-03-26
Mar 27, 2026
Merged

chore: fix typos, grammar, and minor issues across multiple packages#11167
kgryte merged 1 commit intodevelopfrom
philipp/fix-review-2026-03-26

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

@Planeshifter Planeshifter commented Mar 27, 2026

Description

What is the purpose of this pull request?

This pull request:

  • Fixes missing :of method name in benchmark descriptions for fixed-endian-factory and fixed-endian-float32
  • Fixes grammar in type test comments for ndarray/base/copy and ndarray/base/empty-like
  • Fixes verb form in module-level JSDoc for drrss and drsskbn TypeScript declarations ("Compute" -> "Computes")
  • Interleaves benchmark1/benchmark2 in dcircshift C benchmark to match sibling package conventions
  • Adds missing GENERIC to unsupported dtype test list in ndarray/base/nans

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code under my oversight. Issues were identified by reviewing the last commits on develop, then each fix was verified against reference packages before staging.


@stdlib-js/reviewers

- Fix missing `:of` method name in benchmark descriptions for
  `fixed-endian-factory` and `fixed-endian-float32`
- Fix grammar in type test comments for `ndarray/base/copy` and
  `ndarray/base/empty-like`
- Fix verb form in module-level JSDoc for `drrss` and `drsskbn`
  TypeScript declarations ("Compute" -> "Computes")
- Interleave benchmark1/benchmark2 in `dcircshift` C benchmark to
  match sibling package conventions
- Add missing `GENERIC` to unsupported dtype test list in
  `ndarray/base/nans`

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1184/1437$
$\color{green}+82.39%$
$\color{red}155/168$
$\color{green}+92.26%$
$\color{red}23/33$
$\color{green}+69.70%$
$\color{red}1184/1437$
$\color{green}+82.39%$
array/fixed-endian-float32 $\color{green}194/194$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}0/0$
$\color{green}+100.00%$
$\color{green}194/194$
$\color{green}+100.00%$
blas/ext/base/dcircshift $\color{red}461/472$
$\color{green}+97.67%$
$\color{red}28/29$
$\color{green}+96.55%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{red}461/472$
$\color{green}+97.67%$
blas/ext/base/drrss $\color{red}448/450$
$\color{green}+99.56%$
$\color{red}33/34$
$\color{green}+97.06%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{red}448/450$
$\color{green}+99.56%$
blas/ext/base/drsskbn $\color{green}408/408$
$\color{green}+100.00%$
$\color{green}19/19$
$\color{green}+100.00%$
$\color{green}4/4$
$\color{green}+100.00%$
$\color{green}408/408$
$\color{green}+100.00%$
ndarray/base/copy $\color{green}97/97$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}97/97$
$\color{green}+100.00%$
ndarray/base/empty-like $\color{green}149/149$
$\color{green}+100.00%$
$\color{green}9/9$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}149/149$
$\color{green}+100.00%$
ndarray/base/nans $\color{green}103/103$
$\color{green}+100.00%$
$\color{green}5/5$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}103/103$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-js stdlib-js deleted a comment from stdlib-bot Mar 27, 2026
@Planeshifter Planeshifter marked this pull request as ready for review March 27, 2026 05:19
@Planeshifter Planeshifter requested a review from kgryte March 27, 2026 05:19
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 27, 2026
'FLOAT64',
'FLOAT32'
'FLOAT32',
'GENERIC'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not necessary, but it also doesn't hurt.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 27, 2026
@kgryte kgryte merged commit 3bf34ec into develop Mar 27, 2026
45 of 46 checks passed
@kgryte kgryte deleted the philipp/fix-review-2026-03-26 branch March 27, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants